Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 1134613003: Remove unused methods from QuotaPolicyChannelIDStoreTest (Closed)

Created:
5 years, 7 months ago by nharper
Modified:
5 years, 7 months ago
Reviewers:
Ryan Sleevi, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused methods from QuotaPolicyChannelIDStoreTest BUG= Committed: https://crrev.com/2117e7503ed5ee06a9e80e6e02b01786b73ed3b1 Cr-Commit-Position: refs/heads/master@{#329160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -22 lines) Patch
M chrome/browser/net/quota_policy_channel_id_store_unittest.cc View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
nharper
This dead code referenced a file that I'm changing in https://codereview.chromium.org/1076063002/, so I figure I'd ...
5 years, 7 months ago (2015-05-08 03:59:42 UTC) #2
mattm
lgtm
5 years, 7 months ago (2015-05-08 22:36:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134613003/1
5 years, 7 months ago (2015-05-08 22:46:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_rel on ...
5 years, 7 months ago (2015-05-09 03:04:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134613003/1
5 years, 7 months ago (2015-05-11 16:14:53 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 16:56:44 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 16:57:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2117e7503ed5ee06a9e80e6e02b01786b73ed3b1
Cr-Commit-Position: refs/heads/master@{#329160}

Powered by Google App Engine
This is Rietveld 408576698