Issue 11346037: Add an HSTS preload for another alias of Chromium Rietveld.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11346037: Add an HSTS preload for another alias of Chromium Rietveld. (Closed)

Created:
8 years, 1 month ago by palmer

Modified:
8 years, 1 month ago

Reviewers:
agl, Chris Palmer, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add an HSTS preload for another alias of Chromium Rietveld. BUG=158522 TEST=Navigate to codereview.chromium.org and expect to get https://. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164999

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	net/base/transport_security_state_static.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	net/base/transport_security_state_static.json	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/11346037/1

8 years, 1 month ago (2012-10-30 17:04:09 UTC) #3

commit-bot: I haz the power

8 years, 1 month ago (2012-10-30 17:04:13 UTC) #4

Presubmit check for 11346037-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/base/transport_security_state_static.h, line 328, 90 chars

Expand Messages | Collapse Messages