Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: net/quic/quic_write_blocked_list.h

Issue 1134603005: Remove WriteBlockedList::use_stream_to_priority. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_write_blocked_list.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_write_blocked_list.h
diff --git a/net/quic/quic_write_blocked_list.h b/net/quic/quic_write_blocked_list.h
index cb6a89a3ce3ce3b791ba9bf83053939960b4615e..3c08badd6162d03d9e3ca605712c1cb3376a17a2 100644
--- a/net/quic/quic_write_blocked_list.h
+++ b/net/quic/quic_write_blocked_list.h
@@ -24,7 +24,7 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {
static const QuicPriority kHighestPriority;
static const QuicPriority kLowestPriority;
- explicit QuicWriteBlockedList(bool avoid_duplicate_streams);
+ QuicWriteBlockedList();
~QuicWriteBlockedList();
bool HasWriteBlockedDataStreams() const {
@@ -61,7 +61,6 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {
SpdyPriority priority =
base_write_blocked_list_.GetHighestPriorityWriteBlockedList();
QuicStreamId id = base_write_blocked_list_.PopFront(priority);
- blocked_streams_.erase(id);
return id;
}
@@ -80,15 +79,8 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {
return;
}
- if (!base_write_blocked_list_.avoids_inserting_duplicates() &&
- blocked_streams_.find(stream_id) != blocked_streams_.end()) {
- DVLOG(1) << "Stream " << stream_id << " already in write blocked list.";
- return;
- }
-
base_write_blocked_list_.PushBack(
stream_id, static_cast<SpdyPriority>(priority));
- blocked_streams_.insert(stream_id);
return;
}
@@ -100,11 +92,6 @@ class NET_EXPORT_PRIVATE QuicWriteBlockedList {
bool crypto_stream_blocked_;
bool headers_stream_blocked_;
- // Keep track of write blocked streams in a set for faster membership checking
- // than iterating over the base_write_blocked_list_. The contents of this set
- // should mirror the contents of base_write_blocked_list_.
- std::set<QuicStreamId> blocked_streams_;
-
DISALLOW_COPY_AND_ASSIGN(QuicWriteBlockedList);
};
« no previous file with comments | « net/quic/quic_session.cc ('k') | net/quic/quic_write_blocked_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698