Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1134603004: Remove the finch gate from the UWS interstitial (Closed)

Created:
5 years, 7 months ago by felt
Modified:
5 years, 7 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the finch gate from the UWS interstitial The UwS interstitial launch went well, so there's no longer any reason for a Finch gate. This kills the Finch-related logic. BUG=451123 Committed: https://crrev.com/4ec309b8a757ca8c4767157a25622ca1746ed729 Cr-Commit-Position: refs/heads/master@{#329726}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removing unneeded include #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -49 lines) Patch
M chrome/browser/safe_browsing/local_database_manager.cc View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 3 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/safe_browsing/ui_manager.cc View 2 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
felt
mattm, PTAL -- cleanup CL
5 years, 7 months ago (2015-05-13 01:11:58 UTC) #2
mattm
Is there a bug for the finch trial this should be associated with? https://codereview.chromium.org/1134603004/diff/1/chrome/browser/safe_browsing/safe_browsing_util.cc File ...
5 years, 7 months ago (2015-05-13 01:46:11 UTC) #3
felt
On 2015/05/13 01:46:11, mattm wrote: > Is there a bug for the finch trial this ...
5 years, 7 months ago (2015-05-13 01:55:47 UTC) #4
felt
https://codereview.chromium.org/1134603004/diff/1/chrome/browser/safe_browsing/safe_browsing_util.cc File chrome/browser/safe_browsing/safe_browsing_util.cc (right): https://codereview.chromium.org/1134603004/diff/1/chrome/browser/safe_browsing/safe_browsing_util.cc#newcode8 chrome/browser/safe_browsing/safe_browsing_util.cc:8: #include "base/metrics/field_trial.h" On 2015/05/13 01:46:11, mattm wrote: > unused ...
5 years, 7 months ago (2015-05-13 01:56:01 UTC) #5
mattm
lgtm
5 years, 7 months ago (2015-05-13 01:57:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134603004/20001
5 years, 7 months ago (2015-05-13 01:58:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/52342) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-13 02:02:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134603004/40001
5 years, 7 months ago (2015-05-13 20:12:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 22:07:03 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 22:07:52 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ec309b8a757ca8c4767157a25622ca1746ed729
Cr-Commit-Position: refs/heads/master@{#329726}

Powered by Google App Engine
This is Rietveld 408576698