Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1134603002: Update some spinners on ChromeOS to Material. (Closed)

Created:
5 years, 7 months ago by Evan Stade
Modified:
5 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update some spinners on ChromeOS to Material. - share dialog - (photo) gallery - video player - file manager - kiosk apps page BUG=485779 Committed: https://crrev.com/eadeb26673cbdf41d9797feb2799e319b0dc77fe Cr-Commit-Position: refs/heads/master@{#329222}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -91 lines) Patch
M chrome/browser/resources/extensions/chromeos/kiosk_apps.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/css/share_dialog.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/gallery/css/gallery.css View 1 chunk +5 lines, -5 lines 1 comment Download
M ui/file_manager/video_player/css/video_player.css View 2 chunks +2 lines, -2 lines 0 comments Download
D ui/webui/resources/images/spinner.svg View 1 chunk +0 lines, -79 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
I didn't manage to test the kiosk apps change or the file manager change. With ...
5 years, 7 months ago (2015-05-07 22:53:46 UTC) #2
yoshiki
lgtm. Thanks!
5 years, 7 months ago (2015-05-11 06:57:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134603002/1
5 years, 7 months ago (2015-05-11 17:09:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 19:33:12 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 19:35:31 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/eadeb26673cbdf41d9797feb2799e319b0dc77fe
Cr-Commit-Position: refs/heads/master@{#329222}

Powered by Google App Engine
This is Rietveld 408576698