Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 1134593004: Reapply the patch r191685 with fixing the regression issue. (Closed)

Created:
5 years, 7 months ago by samahto
Modified:
5 years, 6 months ago
Reviewers:
keishi, tkent
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reapply the patch r191685 with fixing the regression issue. This also fixes the issue where on cloneNode(true) doesn't copy dynamic updated text instead default text is copied. Orignial bug description and casue of revert. > Revert r191685 "Implement copyNonAttributePropertiesFromElement for HTMLTextAreaElement" >It caused a regression about cloneNode() for <textarea>. > Implement copyNonAttributePropertiesFromElement for > HTMLTextAreaElement > > Before this patch on cloning textarea element checkValidity() gives > incorrect result becasue value is not copied in cloned node. > Now we copy value by overriding copyNonAttributePropertiesFromElement > > BUG=461414, 465365 . > TESTS=Exisitng LayoutTests/fast/forms/checkValidity-on-cloned-node.html >BUG=487352 BUG=487352 TEST=LayoutTests/fast/forms/textarea-cloned-text-match.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196677

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -2 lines) Patch
M LayoutTests/fast/forms/checkValidity-on-cloned-node-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A LayoutTests/fast/forms/textarea-cloned-text-match.html View 1 1 chunk +28 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/textarea-cloned-text-match-expected.html View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/tooLong-check-on-cloned-textcontrol.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/tooLong-check-on-cloned-textcontrol-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
samahto
Review the patch which fixes the regression issue.
5 years, 7 months ago (2015-05-18 15:58:54 UTC) #1
tkent
https://codereview.chromium.org/1134593004/diff/1/LayoutTests/fast/forms/textarea-cloned-text-match.html File LayoutTests/fast/forms/textarea-cloned-text-match.html (right): https://codereview.chromium.org/1134593004/diff/1/LayoutTests/fast/forms/textarea-cloned-text-match.html#newcode10 LayoutTests/fast/forms/textarea-cloned-text-match.html:10: </script> Please add the following two test cases for ...
5 years, 7 months ago (2015-05-19 23:47:38 UTC) #2
samahto
On 2015/05/19 23:47:38, tkent wrote: > https://codereview.chromium.org/1134593004/diff/1/LayoutTests/fast/forms/textarea-cloned-text-match.html > File LayoutTests/fast/forms/textarea-cloned-text-match.html (right): > > https://codereview.chromium.org/1134593004/diff/1/LayoutTests/fast/forms/textarea-cloned-text-match.html#newcode10 > ...
5 years, 6 months ago (2015-06-04 17:23:38 UTC) #3
tkent
lgtm
5 years, 6 months ago (2015-06-05 00:45:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593004/20001
5 years, 6 months ago (2015-06-05 00:45:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65163)
5 years, 6 months ago (2015-06-05 02:25:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593004/20001
5 years, 6 months ago (2015-06-05 02:57:51 UTC) #10
tkent
https://codereview.chromium.org/1134593004/diff/20001/LayoutTests/fast/forms/textarea-cloned-text-match-expected.html File LayoutTests/fast/forms/textarea-cloned-text-match-expected.html (right): https://codereview.chromium.org/1134593004/diff/20001/LayoutTests/fast/forms/textarea-cloned-text-match-expected.html#newcode10 LayoutTests/fast/forms/textarea-cloned-text-match-expected.html:10: <textarea cols="15" rows="2">InitialText</textarea> should remove end-of-line characters between textareas.
5 years, 6 months ago (2015-06-05 03:01:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/65176)
5 years, 6 months ago (2015-06-05 03:54:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134593004/40001
5 years, 6 months ago (2015-06-08 13:28:31 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 15:27:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196677

Powered by Google App Engine
This is Rietveld 408576698