Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1134573002: Give ComputeCapacityForSerialization a minimum capacity (Closed)

Created:
5 years, 7 months ago by adamk
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Give ComputeCapacityForSerialization a minimum capacity This avoids DCHECK failures when passing 0 as the at_least_space_for argument to HashTableBase::New (allowing converting code from non-serialized to serialized without changing callsites). Committed: https://crrev.com/090c78219f57a96913af05b78414fa2aeea3a016 Cr-Commit-Position: refs/heads/master@{#28321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Ran into this when trying to add a new ObjectHashTable member to native contexts.
5 years, 7 months ago (2015-05-07 21:24:58 UTC) #2
Yang
On 2015/05/07 21:24:58, adamk wrote: > Ran into this when trying to add a new ...
5 years, 7 months ago (2015-05-08 04:58:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134573002/1
5 years, 7 months ago (2015-05-08 15:01:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 15:03:41 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 15:03:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/090c78219f57a96913af05b78414fa2aeea3a016
Cr-Commit-Position: refs/heads/master@{#28321}

Powered by Google App Engine
This is Rietveld 408576698