Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2540)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 1134553005: Record SB subresource metrics separately from non-subresource metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 472dc5108a10fb43334762f3b0e697909fba6c38..a11bee0daff5609fa135a2eb87a99435a71169af 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -159,7 +159,7 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(
// This must be done after calculating |interstitial_reason_| above.
// Use same prefix for UMA as for Rappor.
set_metrics_helper(new SecurityInterstitialMetricsHelper(
- web_contents, request_url(), GetMetricPrefix(), GetMetricPrefix(),
+ web_contents, request_url(), GetMetricPrefix(), GetRapporPrefix(),
SecurityInterstitialMetricsHelper::REPORT_RAPPOR,
GetSamplingEventName()));
metrics_helper()->RecordUserDecision(SecurityInterstitialMetricsHelper::SHOW);
@@ -493,6 +493,20 @@ bool SafeBrowsingBlockingPage::IsMainPageLoadBlocked(
}
std::string SafeBrowsingBlockingPage::GetMetricPrefix() const {
+ bool primary_subresource = unsafe_resources_[0].is_subresource;
+ switch (interstitial_reason_) {
+ case SB_REASON_MALWARE:
+ return primary_subresource ? "malware_subresource" : "malware";
+ case SB_REASON_HARMFUL:
+ return primary_subresource ? "harmful_subresource" : "harmful";
+ case SB_REASON_PHISHING:
+ return primary_subresource ? "phishing_subresource" : "phishing";
+ }
+ NOTREACHED();
+ return std::string();
+}
+
+std::string SafeBrowsingBlockingPage::GetRapporPrefix() const {
switch (interstitial_reason_) {
case SB_REASON_MALWARE:
return "malware";
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_blocking_page.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698