Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 1134553005: Record SB subresource metrics separately from non-subresource metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Classes for managing the SafeBrowsing interstitial pages. 5 // Classes for managing the SafeBrowsing interstitial pages.
6 // 6 //
7 // When a user is about to visit a page the SafeBrowsing system has deemed to 7 // When a user is about to visit a page the SafeBrowsing system has deemed to
8 // be malicious, either as malware or a phishing page, we show an interstitial 8 // be malicious, either as malware or a phishing page, we show an interstitial
9 // page with some options (go back, continue) to give the user a chance to avoid 9 // page with some options (go back, continue) to give the user a chance to avoid
10 // the harmful page. 10 // the harmful page.
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
179 179
180 private: 180 private:
181 // Fills the passed dictionary with the values to be passed to the template 181 // Fills the passed dictionary with the values to be passed to the template
182 // when creating the HTML. 182 // when creating the HTML.
183 void PopulateExtendedReportingOption(base::DictionaryValue* load_time_data); 183 void PopulateExtendedReportingOption(base::DictionaryValue* load_time_data);
184 void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data); 184 void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);
185 void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data); 185 void PopulateHarmfulLoadTimeData(base::DictionaryValue* load_time_data);
186 void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data); 186 void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);
187 187
188 std::string GetMetricPrefix() const; 188 std::string GetMetricPrefix() const;
189 std::string GetRapporPrefix() const;
189 std::string GetSamplingEventName() const; 190 std::string GetSamplingEventName() const;
190 191
191 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPage); 192 DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPage);
192 }; 193 };
193 194
194 // Factory for creating SafeBrowsingBlockingPage. Useful for tests. 195 // Factory for creating SafeBrowsingBlockingPage. Useful for tests.
195 class SafeBrowsingBlockingPageFactory { 196 class SafeBrowsingBlockingPageFactory {
196 public: 197 public:
197 virtual ~SafeBrowsingBlockingPageFactory() { } 198 virtual ~SafeBrowsingBlockingPageFactory() { }
198 199
199 virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage( 200 virtual SafeBrowsingBlockingPage* CreateSafeBrowsingPage(
200 SafeBrowsingUIManager* ui_manager, 201 SafeBrowsingUIManager* ui_manager,
201 content::WebContents* web_contents, 202 content::WebContents* web_contents,
202 const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) = 0; 203 const SafeBrowsingBlockingPage::UnsafeResourceList& unsafe_resources) = 0;
203 }; 204 };
204 205
205 #endif // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_ 206 #endif // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_BLOCKING_PAGE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698