Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 1134543002: [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue (Closed)

Created:
5 years, 7 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue The test reproduces the condition which was triggering an infinite loop inside GinJavaBridgeDispatcherHost::RenderFrameDeleted. Verified that the test indeed hangs up and timeouts if the fix is removed. BUG=484927 Committed: https://crrev.com/326214e563fba72a044205e784c8f4f7bfef2f85 Cr-Commit-Position: refs/heads/master@{#328900}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +55 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
mnaganov (inactive)
PTAL, addressing your comment about https://codereview.chromium.org/1124003003/
5 years, 7 months ago (2015-05-07 17:26:24 UTC) #2
sgurun-gerrit only
lgtm
5 years, 7 months ago (2015-05-07 23:36:12 UTC) #3
mnaganov (inactive)
Ted can you please bless this?
5 years, 7 months ago (2015-05-07 23:42:02 UTC) #5
Ted C
lgtm
5 years, 7 months ago (2015-05-08 01:02:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134543002/1
5 years, 7 months ago (2015-05-08 01:09:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 01:38:58 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/326214e563fba72a044205e784c8f4f7bfef2f85 Cr-Commit-Position: refs/heads/master@{#328900}
5 years, 7 months ago (2015-05-08 01:40:41 UTC) #10
jbudorick
5 years, 7 months ago (2015-05-08 21:32:36 UTC) #11

Powered by Google App Engine
This is Rietveld 408576698