Fixed AppListServceUnitTest so it tests what it says it's testing.

Fixed AppListServceUnitTest so it tests what it says it's testing.

FakeProfileStore now returns the real kProfileLastUsed (from the pref
store), instead of a dummy value. This means that tests for code that
sets or manipulates the kProfileLastUsed pref will behave correctly.

AppListServceUnitTest.RemovedProfileResetsToInitialProfile now properly
tests the behaviour of RemoveProfile (that it clears kAppListProfile,
and that GetProfilePath returns the initial profile when kAppListProfile
is missing). Previously, it did not distinguish between the initial and
last used profiles.

AppListServiceUnitTest.RemovedProfileResetsToLastUsedProfileIfExists
also tests that the kAppListProfile has been set correctly.

BUG=487951
Committed: https://crrev.com/461a6f002efc93a8763c23c956b99bb1e437c3f6
Cr-Commit-Position: refs/heads/master@{#330319}

[Matt Giuca, 2015-05-15 09:08:53]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-15 09:09:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134533007/1

[Matt Giuca, 2015-05-15 09:27:43]

mgiuca@chromium.org changed reviewers:
+ tapted@chromium.org

[commit-bot: I haz the power, 2015-05-15 09:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 09:37:12]

Dry run: This issue passed the CQ dry run.

[tapted, 2015-05-15 09:40:58]

lgtm

https://codereview.chromium.org/1134533007/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/test/fake_profile_store.h (right):

https://codereview.chromium.org/1134533007/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/test/fake_profile_store.h:18: explicit
FakeProfileStore(const base::FilePath& user_data_dir,
nit: explicit not needed (although that's not a new thing)

[Bernhard Bauer, 2015-05-15 15:03:47]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-05-15 15:03:47]

LGTM, thanks!

[Matt Giuca, 2015-05-18 00:01:38]

https://codereview.chromium.org/1134533007/diff/1/chrome/browser/ui/app_list/...
File chrome/browser/ui/app_list/test/fake_profile_store.h (right):

https://codereview.chromium.org/1134533007/diff/1/chrome/browser/ui/app_list/...
chrome/browser/ui/app_list/test/fake_profile_store.h:18: explicit
FakeProfileStore(const base::FilePath& user_data_dir,
On 2015/05/15 09:40:58, tapted wrote:
> nit: explicit not needed (although that's not a new thing)

Done.

[Matt Giuca, 2015-05-18 00:03:32]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2015-05-18 00:03:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
tapted@chromium.org
Link to the patchset: https://codereview.chromium.org/1134533007/#ps20001
(title: "Remove explicit.")

[commit-bot: I haz the power, 2015-05-18 00:03:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134533007/20001

[commit-bot: I haz the power, 2015-05-18 00:52:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-18 11:33:16]

Patchset 2 (id:??) landed as
https://crrev.com/461a6f002efc93a8763c23c956b99bb1e437c3f6
Cr-Commit-Position: refs/heads/master@{#330319}