Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1134513003: We don't use boxBlurY. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

We don't use boxBlurY. Also noticed nobody sets SK_DISABLE_BLUR_DIVISION_OPTIMIZATION. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4525f438a84147989de080e89cf1d97bc46eb546

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -24 lines) Patch
M src/effects/SkBlurImageFilter.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/opts/SkBlurImage_opts.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkBlurImage_opts_SSE2.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkBlurImage_opts_SSE2.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBlurImage_opts_SSE4.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkBlurImage_opts_SSE4.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M src/opts/SkBlurImage_opts_arm.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/opts/SkBlurImage_opts_neon.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkBlurImage_opts_neon.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBlurImage_opts_none.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +2 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134513003/1
5 years, 7 months ago (2015-05-07 17:43:04 UTC) #2
mtklein
5 years, 7 months ago (2015-05-07 17:45:45 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-07 17:48:52 UTC) #6
mtklein
lgtm
5 years, 7 months ago (2015-05-07 17:51:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134513003/1
5 years, 7 months ago (2015-05-07 17:51:24 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 17:52:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4525f438a84147989de080e89cf1d97bc46eb546

Powered by Google App Engine
This is Rietveld 408576698