Issue 11345038: Fix for audiogainnode/gain node naming in current Chrome and Safari.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11345038: Fix for audiogainnode/gain node naming in current Chrome and Safari. (Closed)

Created:
8 years, 1 month ago by Emily Fortuna

Modified:
8 years, 1 month ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix for audiogainnode/gain node naming in current Chrome and Safari. Committed: https://code.google.com/p/dart/source/detail?r=14310

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	lib/compiler/implementation/lib/native_helper.dart	View	1 2 3	2 chunks	+14 lines, -0 lines	0 comments	Download
	M	tests/html/audiocontext_test.dart	View	1 2 3	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

PTAL. I don't have great test cases for all of these yet (working on it), ...

8 years, 1 month ago (2012-10-30 19:59:07 UTC) #2

sra1

8 years, 1 month ago (2012-10-30 20:39:16 UTC) #3

lgtm with tweaks if you want to add a test case or two in audiocontext_test in a
separate CL.

https://codereview.chromium.org/11345038/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/lib/native_helper.dart (right):

https://codereview.chromium.org/11345038/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/lib/native_helper.dart:14: if (name ==
'AudioPannerNodeConstructor') return 'PannerNodeConstructor';
Leave AudioPannerNodeConstructor out.  It is for JavaScript constructor or
instanceof checks.

https://codereview.chromium.org/11345038/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/lib/native_helper.dart:17: if (name ==
'RealtimeAnalyserNode') return 'AnalyserNode';
I would sort all these.

Expand Messages | Collapse Messages