[dart2dart] Support cosntructor redirects.

lib/compiler/implementation/dart_backend/renamer.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart_backend;
 
 Function get _compareNodes =>
     compareBy((n) => n.getBeginToken().charOffset);
 
 typedef String _Renamer(Renamable renamable);
@@ skipping 83 matching lines @@
       for (Link<DartType> link = argumentsLink.tail; !link.isEmpty;
            link = link.tail) {
         result.add(',');
         result.add(renameType(link.head, renameElement));
       }
       result.add('>');
     }
     return result.toString();
   }
 
-  String renameConstructor(Element element, DartType type,
+  String renameConstructor(Element element, ConstructorPlaceholder placeholder,
       Function renameString, Function renameElement) {
     assert(element.isConstructor());
     StringBuffer result = new StringBuffer();
     String name = element.name.slowToString();
     if (element.name != element.getEnclosingClass().name) {
       // Named constructor or factory. Is there a more reliable way to check
       // this case?
-      result.add(renameType(type, renameElement));
-      result.add('.');
+      if (!placeholder.isRedirectingCall) {

[Anton Muhin, 2012/10/30 15:23:44]

where do we add super./this. prefix?

[Roman, 2012/10/30 15:52:09]

Nowhere, the placeholder is placed for selector node:
receiver: "this" / "super"
selector: constructor name

+        result.add(renameType(placeholder.type, renameElement));
+        result.add('.');
+      }
       String prefix = '${element.getEnclosingClass().name.slowToString()}\$';
       if (!name.startsWith(prefix)) {
         // Factory for another interface (that is going away soon).
         compiler.internalErrorOnElement(element,
             "Factory constructors for external interfaces are not supported.");
       }
       name = name.substring(prefix.length);
       result.add(name);
     } else {
-      result.add(renameType(type, renameElement));
+      assert(!placeholder.isRedirectingCall);
+      if (placeholder.isRedirectingCall) throw 'e';

[Anton Muhin, 2012/10/30 15:23:44]

isn't assert enough?

[Roman, 2012/10/30 15:52:09]

Sorry, that was my way to ensure that placeholder is not redirecting call during
test run :) Removed.

+      result.add(renameType(placeholder.type, renameElement));
     }
     return result.toString();
   }
 
   Function makeElementRenamer(rename, generateUniqueName) => (element) {
     assert(Elements.isStaticOrTopLevel(element)
            || element is TypeVariableElement);
     // TODO(smok): We may want to reuse class static field and method names.
     String originalName = element.name.slowToString();
     LibraryElement library = element.getLibrary();
@@ skipping 140 matching lines @@
           identifier, usedMemberIdentifiers.contains);
       renameNodes(nodes, (_) => newIdentifier);
     });
   }
 
   // Rename constructors.
   placeholderCollector.constructorPlaceholders.forEach(
       (Element constructor, List<ConstructorPlaceholder> placeholders) {
         for (ConstructorPlaceholder ph in placeholders) {
           renames[ph.node] =
-              renameConstructor(constructor, ph.type, rename, renameElement);
+              renameConstructor(constructor, ph, rename, renameElement);
         }
   });
   sortedForEach(placeholderCollector.privateNodes, (library, nodes) {
     renameNodes(nodes, (node) => rename(library, node.source.slowToString()));
   });
   renameNodes(placeholderCollector.unresolvedNodes,
       (_) => generateUniqueName('Unresolved'));
   renameNodes(placeholderCollector.nullNodes, (_) => '');
   if (cutDeclarationTypes) {
     for (DeclarationTypePlaceholder placeholder in
@@ skipping 46 matching lines @@
     index ~/= firstCharAlphabet.length;
     int length = otherCharsAlphabet.length;
     while (index >= length) {
       resultBuilder.add(otherCharsAlphabet[index % length]);
       index ~/= length;
     }
     resultBuilder.add(otherCharsAlphabet[index]);
     return resultBuilder.toString();
   }
 }