Issue 11345017: Create ash memory monitor

Issue 11345017: Create ash memory monitor (Closed)

Created:
8 years, 1 month ago by DaveMoore

Modified:
8 years, 1 month ago

Reviewers:
sadrul, Ben Goodger (Google), piman

CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Create ash memory monitor BUG=None TEST=Enable via about:flags/enable-memory-monitor Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166061

Patch Set 2 : nicer formatting #

Patch Set 6 : Fix android failure #

Patch Set 7 : Make tray linux specific #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -1 line)			Patch
M	ash/ash.gyp	View	1 2 3 4 5 6	2 chunks	+8 lines, -0 lines	0 comments	Download
M	ash/ash_switches.h	View	1 2 3 4 5 6	2 chunks	+5 lines, -0 lines	0 comments	Download
M	ash/ash_switches.cc	View	1 2 3 4 5 6	1 chunk	+5 lines, -0 lines	0 comments	Download
A	ash/system/monitor/tray_monitor.h	View	1 2 3 4	1 chunk	+39 lines, -0 lines	0 comments	Download
A	ash/system/monitor/tray_monitor.cc	View	1 2 3 4	1 chunk	+62 lines, -0 lines	0 comments	Download
M	ash/system/tray/system_tray.cc	View	1 2 3 4 5 6	4 chunks	+11 lines, -0 lines	0 comments	Download
M	base/process_util.h	View	1 2 3 4 5 6	1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/process_util_linux.cc	View	1 2 3 4 5	1 chunk	+18 lines, -0 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	chrome/browser/about_flags.cc	View	1 2 3 4 5 6	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

piman: gpu memory stuff sadrul: system tray stuff ben: OWNERS

8 years, 1 month ago (2012-10-29 22:55:24 UTC) #1

sadrul

https://codereview.chromium.org/11345017/diff/6002/ash/system/monitor/tray_monitor.cc File ash/system/monitor/tray_monitor.cc (right): https://codereview.chromium.org/11345017/diff/6002/ash/system/monitor/tray_monitor.cc#newcode5 ash/system/monitor/tray_monitor.cc:5: #include "ash/system/monitor/tray_monitor.h" new line after this https://codereview.chromium.org/11345017/diff/6002/ash/system/monitor/tray_monitor.cc#newcode32 ash/system/monitor/tray_monitor.cc:32: label_ ...

8 years, 1 month ago (2012-10-29 23:50:57 UTC) #4

DaveMoore

8 years, 1 month ago (2012-10-30 16:18:49 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/11345017/6004

8 years, 1 month ago (2012-10-30 16:19:12 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

8 years, 1 month ago (2012-10-30 16:32:31 UTC) #7

sadrul

8 years, 1 month ago (2012-10-30 16:44:47 UTC) #8

http://codereview.chromium.org/11345017/diff/6002/ash/system/monitor/tray_mon...
File ash/system/monitor/tray_monitor.cc (right):

http://codereview.chromium.org/11345017/diff/6002/ash/system/monitor/tray_mon...
ash/system/monitor/tray_monitor.cc:32: label_ = view->label();
On 2012/10/30 16:18:49, DaveMoore wrote:
> On 2012/10/29 23:50:57, sadrul wrote:
> > You should reset |label_| to NULL in DestroyTrayView override
> 
> Done.

I actually meant from TrayMonitor::DestroyTrayView

Expand Messages | Collapse Messages