Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1134493004: Add gypcmd extension wildcard to git ignore. (Closed)

Created:
5 years, 7 months ago by Will Harris
Modified:
5 years, 7 months ago
Reviewers:
bradnelson, Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gypcmd extension wildcard to git ignore. These files are generated by the msvs-ninja gyp generator. BUG=481707 Committed: https://crrev.com/538f17a292590843ab3bbb8c202d815234e66e76 Cr-Commit-Position: refs/heads/master@{#330618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Will Harris
5 years, 7 months ago (2015-05-19 21:04:30 UTC) #2
Sam Clegg
On 2015/05/19 21:04:30, Will Harris wrote: My understanding is that these are not generated in ...
5 years, 7 months ago (2015-05-19 21:05:57 UTC) #3
Will Harris
I still get them on every checkout - see the bug for details.
5 years, 7 months ago (2015-05-19 21:06:58 UTC) #4
Sam Clegg
On 2015/05/19 21:06:58, Will Harris wrote: > I still get them on every checkout - ...
5 years, 7 months ago (2015-05-19 21:23:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134493004/1
5 years, 7 months ago (2015-05-19 21:32:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 21:44:14 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:45:52 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/538f17a292590843ab3bbb8c202d815234e66e76
Cr-Commit-Position: refs/heads/master@{#330618}

Powered by Google App Engine
This is Rietveld 408576698