src/x64/lithium-codegen-x64.cc - Issue 1134483002: Allow loading holes from holey smi arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 1134483002: Allow loading holes from holey smi arrays (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Update the DCHECK Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index eb8274bfd89bc46d84ef1f6793ecf7be86cd2879..e030826292ac1b60f1f9b360d045164bab5b1215 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3264,7 +3264,8 @@ void LCodeGen::DoLoadKeyedFixedArray(LLoadKeyed* instr) {

DeoptimizeIf(equal, instr, Deoptimizer::kHole);

}

} else if (hinstr->hole_mode() == CONVERT_HOLE_TO_UNDEFINED) {

- DCHECK(hinstr->elements_kind() == FAST_HOLEY_ELEMENTS);

+ DCHECK(hinstr->elements_kind() == FAST_HOLEY_SMI_ELEMENTS ||

+ hinstr->elements_kind() == FAST_HOLEY_ELEMENTS);

Label done;

__ CompareRoot(result, Heap::kTheHoleValueRootIndex);

__ j(not_equal, &done);

« no previous file with comments | « src/ppc/lithium-codegen-ppc.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »