Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1134483002: Allow loading holes from holey smi arrays (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow loading holes from holey smi arrays BUG= Committed: https://crrev.com/eab5bb5390fab79d063f29398377c6d181963dde Cr-Commit-Position: refs/heads/master@{#28298}

Patch Set 1 #

Patch Set 2 : Update the DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-07 13:02:10 UTC) #2
mvstanton
LGTM.
5 years, 7 months ago (2015-05-07 13:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134483002/20001
5 years, 7 months ago (2015-05-07 13:26:26 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 14:02:03 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eab5bb5390fab79d063f29398377c6d181963dde Cr-Commit-Position: refs/heads/master@{#28298}
5 years, 7 months ago (2015-05-07 14:02:17 UTC) #8
Toon Verwaest
5 years, 7 months ago (2015-05-08 07:28:33 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1131203002/ by verwaest@chromium.org.

The reason for reverting is: Shouldn't unconditionally load holes since it tanks
performance. I'll change it in a follow-up to only do it if the IC ever saw it
happen..

Powered by Google App Engine
This is Rietveld 408576698