Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1134453002: Revert of Remove Scope::scope_uses_arguments_ flag (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
v8-dev, rossberg, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Remove Scope::scope_uses_arguments_ flag (patchset #1 id:1 of https://codereview.chromium.org/1124233002/) Reason for revert: [Sheriff] Need to fix compilation after this revert: https://chromium.googlesource.com/v8/v8/+/5cab6be83a44567a3ee5747d728a399025d38411 Original issue's description: > Remove Scope::scope_uses_arguments_ flag > > Use of arguments is tracked as a variable, like any other variable. > > R=arv@chromium.org > LOG=N > BUG= > > Committed: https://crrev.com/d4ea33f480243fb5b7d2cca6edddcaa3e9478e29 > Cr-Commit-Position: refs/heads/master@{#28271} TBR=arv@chromium.org,wingo@igalia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/b8ff13111a34553bf17961b9550dcbb7380273f3 Cr-Commit-Position: refs/heads/master@{#28284}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M src/preparser.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/scopes.h View 4 chunks +10 lines, -0 lines 0 comments Download
M src/scopes.cc View 5 chunks +10 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of Remove Scope::scope_uses_arguments_ flag
5 years, 7 months ago (2015-05-07 07:42:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134453002/1
5 years, 7 months ago (2015-05-07 07:42:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 07:42:24 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b8ff13111a34553bf17961b9550dcbb7380273f3 Cr-Commit-Position: refs/heads/master@{#28284}
5 years, 7 months ago (2015-05-07 07:42:42 UTC) #4
Michael Achenbach
5 years, 7 months ago (2015-05-07 07:56:02 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1135463002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Speculative reland - maybe this revert
wasn't necessary....

Powered by Google App Engine
This is Rietveld 408576698