Issue 1134443005: Fixes android mandoline ui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1134443005: Fixes android mandoline ui (Closed)

Created:
5 years, 7 months ago by sky

Modified:
5 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fixes android mandoline ui Latest changes broke the android side. R=ben@chromium.org BUG=none TEST=none Committed: https://crrev.com/d23fc1d01d40d1e8914905e3bd4d7fffca47749a Cr-Commit-Position: refs/heads/master@{#329702}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	mandoline/ui/browser/android/android_ui.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	mandoline/ui/browser/android/android_ui.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134443005/1

5 years, 7 months ago (2015-05-13 19:53:53 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 19:59:27 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d23fc1d01d40d1e8914905e3bd4d7fffca47749a
Cr-Commit-Position: refs/heads/master@{#329702}