Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: tests/language/mint_compares.dart

Issue 11344011: Relational comparisons for unboxed mints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: better test coverage Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/mint_compares.dart
===================================================================
--- tests/language/mint_compares.dart (revision 14174)
+++ tests/language/mint_compares.dart (working copy)
@@ -4,7 +4,6 @@
// Test compares on 64-bit integers.
-
compareTest() {
Expect.isFalse(4294967296 < 6);
Expect.isFalse(4294967296 < 4294967296);
@@ -52,9 +51,46 @@
Expect.isFalse(-4294967296 < -184467440737095516150);
}
+compareTest2(lt, lte, gt, gte) {
+ Expect.isFalse(lt(4294967296, 6));
+ Expect.isFalse(lte(4294967296, 6));
+ Expect.isTrue(gt(4294967296, 6));
+ Expect.isTrue(gte(4294967296, 6));
+ Expect.isTrue(lte(-1, -1));
+ Expect.isTrue(gte(-1, -1));
+ Expect.isTrue(lte(-2, -1));
+ Expect.isFalse(gte(-2, -1));
+ Expect.isTrue(lte(-4294967296, -1));
+ Expect.isFalse(gte(-4294967296, -1));
+
+ Expect.isTrue(lt(-2, -1));
+ Expect.isFalse(gt(-2, -1));
+ Expect.isTrue(lt(-4294967296, -1));
+ Expect.isFalse(gt(-4294967296, -1));
+
+ Expect.isFalse(lt(-1, -4294967296));
+ Expect.isTrue(gt(-1, -4294967296));
+ Expect.isFalse(lt(2, -2));
+ Expect.isTrue(gt(2, -2));
+ Expect.isFalse(lt(4294967296, -1));
+ Expect.isTrue(gt(4294967296, -1));
+}
+
+bool lt1(a, b) => a < b;
+bool lte1(a, b) => a <= b;
+bool gt1(a, b) => a > b;
+bool gte1(a, b) => a >= b;
+
+bool lt2(a, b) => a < b ? true : false;
+bool lte2(a, b) => a <= b ? true : false;
+bool gt2(a, b) => a > b ? true : false;
+bool gte2(a, b) => a >= b ? true : false;
+
main() {
- for (var i = 0; i < 100; i++) {
+ for (var i = 0; i < 1000; i++) {
compareTest();
+ compareTest2(lt1, lte1, gt1, gte1);
+ compareTest2(lt2, lte2, gt2, gte2);
}
}
« runtime/vm/intermediate_language_ia32.cc ('K') | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698