Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1044)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intermediate_language.h

Issue 11344011: Relational comparisons for unboxed mints. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: better test coverage Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/flow_graph_optimizer.cc ('K') | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
===================================================================
--- runtime/vm/intermediate_language.h (revision 14174)
+++ runtime/vm/intermediate_language.h (working copy)
@@ -2325,10 +2325,12 @@
virtual bool CanDeoptimize() const {
return (operands_class_id() != kDoubleCid)
+ && (operands_class_id() != kMintCid)
&& (operands_class_id() != kSmiCid);
}
virtual bool HasSideEffect() const {
return (operands_class_id() != kDoubleCid)
+ && (operands_class_id() != kMintCid)
&& (operands_class_id() != kSmiCid);
}
@@ -2344,7 +2346,9 @@
virtual Representation RequiredInputRepresentation(intptr_t idx) const {
ASSERT((idx == 0) || (idx == 1));
- return (operands_class_id() == kDoubleCid) ? kUnboxedDouble : kTagged;
+ if (operands_class_id() == kDoubleCid) return kUnboxedDouble;
+ if (operands_class_id() == kMintCid) return kUnboxedMint;
+ return kTagged;
}
private:
« runtime/vm/flow_graph_optimizer.cc ('K') | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698