Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Issue 1134383002: support basic table output. (Closed)

Created:
5 years, 7 months ago by David Tseng
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dtseng+watch_chromium.org, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

support basic table output. Committed: https://crrev.com/c9ae2d4f457e21bee562ada008e483b8591c84fe Cr-Commit-Position: refs/heads/master@{#330436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
David Tseng
5 years, 7 months ago (2015-05-13 23:10:24 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-18 16:46:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134383002/1
5 years, 7 months ago (2015-05-18 21:02:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 21:53:24 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9ae2d4f457e21bee562ada008e483b8591c84fe
Cr-Commit-Position: refs/heads/master@{#330436}

Powered by Google App Engine
This is Rietveld 408576698