Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1134363002: Enable old-style-class lint check for telemetry & perf. (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable old-style-class lint check for telemetry & perf. BUG=475714 Committed: https://crrev.com/bd11f56bf5f5fd456b19fcf98d523a9ef408d67e Cr-Commit-Position: refs/heads/master@{#329677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/perf/metrics/webrtc_stats_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/pylintrc View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/pylintrc View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nednguyen
5 years, 7 months ago (2015-05-13 16:57:46 UTC) #2
sullivan
lgtm Wow, didn't realize this wasn't being checked!
5 years, 7 months ago (2015-05-13 17:00:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134363002/1
5 years, 7 months ago (2015-05-13 17:08:59 UTC) #5
nednguyen
On 2015/05/13 17:00:47, sullivan wrote: > lgtm > > Wow, didn't realize this wasn't being ...
5 years, 7 months ago (2015-05-13 17:09:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 18:14:10 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:14:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd11f56bf5f5fd456b19fcf98d523a9ef408d67e
Cr-Commit-Position: refs/heads/master@{#329677}

Powered by Google App Engine
This is Rietveld 408576698