Add --split-apk-path flag to apk_install.py, and install-multiple logic to adb_wrapper

Add --split-apk-path flag to apk_install.py, and install-multiple logic to adb_wrapper

There's a TODO for using split-select, but it won't be necessary until
we have resource splits being generated.

BUG=447152
Committed: https://crrev.com/845f198cd6e47f25d68355898fdff474796e2165
Cr-Commit-Position: refs/heads/master@{#329844}

[agrieve, 2015-05-13 14:15:58]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2015-05-13 15:15:42]

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
build/android/gyp/apk_install.py:94: device.Install(options.apk_path,
reinstall=True, split_paths=active_splits)
Why should we do this instead of just installing each apk in active_splits?

https://codereview.chromium.org/1134353002/diff/1/build/android/pylib/device/...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/pylib/device/...
build/android/pylib/device/adb_wrapper.py:409: cmd = ['install-multiple']
This should be in its own InstallMultiple function if we want it at all. (I'm
not entirely convinced that we do, though.)

[agrieve, 2015-05-13 15:47:46]

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
build/android/gyp/apk_install.py:94: device.Install(options.apk_path,
reinstall=True, split_paths=active_splits)
On 2015/05/13 15:15:42, jbudorick wrote:
> Why should we do this instead of just installing each apk in active_splits?

I'm guessing you're question is about using "adb install-multiple" vs "adb
install" for each split?
The answer is that you can't. Splits are not normal .apks, and they can only be
installed via "adb install-multiple"

https://codereview.chromium.org/1134353002/diff/1/build/android/pylib/device/...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/pylib/device/...
build/android/pylib/device/adb_wrapper.py:409: cmd = ['install-multiple']
On 2015/05/13 15:15:42, jbudorick wrote:
> This should be in its own InstallMultiple function if we want it at all. (I'm
> not entirely convinced that we do, though.)

Done.

[jbudorick, 2015-05-13 15:49:15]

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
build/android/gyp/apk_install.py:94: device.Install(options.apk_path,
reinstall=True, split_paths=active_splits)
On 2015/05/13 15:47:46, agrieve wrote:
> On 2015/05/13 15:15:42, jbudorick wrote:
> > Why should we do this instead of just installing each apk in active_splits?
> 
> I'm guessing you're question is about using "adb install-multiple" vs "adb
> install" for each split?
> The answer is that you can't. Splits are not normal .apks, and they can only
be
> installed via "adb install-multiple"

Yeah, that was the question. Sorry, should've phrased it better.

In that case, this should not go through DeviceUtils.Install.

[agrieve, 2015-05-13 16:10:41]

On 2015/05/13 15:49:15, jbudorick wrote:
>
https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
> File build/android/gyp/apk_install.py (right):
> 
>
https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
> build/android/gyp/apk_install.py:94: device.Install(options.apk_path,
> reinstall=True, split_paths=active_splits)
> On 2015/05/13 15:47:46, agrieve wrote:
> > On 2015/05/13 15:15:42, jbudorick wrote:
> > > Why should we do this instead of just installing each apk in
active_splits?
> > 
> > I'm guessing you're question is about using "adb install-multiple" vs "adb
> > install" for each split?
> > The answer is that you can't. Splits are not normal .apks, and they can only
> be
> > installed via "adb install-multiple"
> 
> Yeah, that was the question. Sorry, should've phrased it better.
> 
> In that case, this should not go through DeviceUtils.Install.

Makes sense. Done.

[jbudorick, 2015-05-13 16:15:07]

lgtm w/ nits

https://codereview.chromium.org/1134353002/diff/40001/build/android/pylib/dev...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/1134353002/diff/40001/build/android/pylib/dev...
build/android/pylib/device/adb_wrapper.py:419: sd_card=False, timeout=60*2,
retries=_DEFAULT_RETRIES,
nits:
 - indentation is off
 - timeout and retries should be the last two parameters

[agrieve1, 2015-05-13 17:22:03]

agrieve@google.com changed reviewers:
+ agrieve@google.com

[agrieve1, 2015-05-13 17:22:04]

Thanks for the speedy review! :)

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
File build/android/gyp/apk_install.py (right):

https://codereview.chromium.org/1134353002/diff/1/build/android/gyp/apk_insta...
build/android/gyp/apk_install.py:94: device.Install(options.apk_path,
reinstall=True, split_paths=active_splits)
On 2015/05/13 15:15:42, jbudorick wrote:
> Why should we do this instead of just installing each apk in active_splits?

I'm guessing you're question is about using "adb install-multiple" vs "adb
install" for each split?
The answer is that you can't. Splits are not normal .apks, and they can only be
installed via "adb install-multiple"

https://codereview.chromium.org/1134353002/diff/40001/build/android/pylib/dev...
File build/android/pylib/device/adb_wrapper.py (right):

https://codereview.chromium.org/1134353002/diff/40001/build/android/pylib/dev...
build/android/pylib/device/adb_wrapper.py:419: sd_card=False, timeout=60*2,
retries=_DEFAULT_RETRIES,
On 2015/05/13 16:15:07, jbudorick wrote:
> nits:
>  - indentation is off
>  - timeout and retries should be the last two parameters

Done.

[agrieve, 2015-05-14 13:54:08]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-05-14 13:54:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/1134353002/#ps60001
(title: "Fix indentation")

[commit-bot: I haz the power, 2015-05-14 13:54:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134353002/60001

[commit-bot: I haz the power, 2015-05-14 13:58:30]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-14 13:59:20]

Patchset 4 (id:??) landed as
https://crrev.com/845f198cd6e47f25d68355898fdff474796e2165
Cr-Commit-Position: refs/heads/master@{#329844}