chrome/browser/password_manager/password_manager_util.h - Issue 1134343002: [Password Manager] Fix IsEnabledSmartLockBranding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_util.h

Issue 1134343002: [Password Manager] Fix IsEnabledSmartLockBranding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@400674_486739_return_values_IsPasswordSyncEnabled

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.cc ('k') | chrome/browser/password_manager/password_manager_util.cc » ('j') | chrome/browser/ui/passwords/password_bubble_experiment.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_util.h

diff --git a/chrome/browser/password_manager/password_manager_util.h b/chrome/browser/password_manager/password_manager_util.h

index 6556269b87c48d39bc4ad400ca82e8d37aa13358..f06964dce8524ed19c6b4c6d8af6f2f8dab1ad07 100644

--- a/chrome/browser/password_manager/password_manager_util.h

+++ b/chrome/browser/password_manager/password_manager_util.h

@@ -7,8 +7,11 @@

#include "base/basictypes.h"

#include "base/callback.h"

+#include "components/password_manager/core/browser/password_manager_client.h"

#include "ui/gfx/native_widget_types.h"

+class ProfileSyncService;

namespace password_manager_util {

enum OsPasswordStatus {

@@ -34,6 +37,10 @@ bool AuthenticateUser(gfx::NativeWindow window);

// is invoked on UI thread with result.

void GetOsPasswordStatus(const base::Callback<void(OsPasswordStatus)>& reply);

+// Reports whether and how passwords are currently synced.

engedy 2015/05/13 14:41:20 nit: We should clarify in the comments that |sync_

vabr (Chromium) 2015/05/13 14:55:06 Done.

+password_manager::PasswordSyncState GetPasswordSyncState(

+ const ProfileSyncService* sync_service);

} // namespace password_manager_util

#endif // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_UTIL_H_