Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Side by Side Diff: chrome/browser/ui/passwords/password_bubble_experiment.cc

Issue 1134343002: [Password Manager] Fix IsEnabledSmartLockBranding (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@400674_486739_return_values_IsPasswordSyncEnabled
Patch Set: Comments addressed Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/password_manager/password_manager_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/passwords/password_bubble_experiment.h" 5 #include "chrome/browser/ui/passwords/password_bubble_experiment.h"
6 6
7 #include "base/metrics/field_trial.h" 7 #include "base/metrics/field_trial.h"
8 #include "chrome/browser/password_manager/password_manager_util.h"
8 #include "chrome/browser/signin/signin_manager_factory.h" 9 #include "chrome/browser/signin/signin_manager_factory.h"
9 #include "components/signin/core/browser/signin_manager.h" 10 #include "chrome/browser/sync/profile_sync_service_factory.h"
10 11
11 namespace password_bubble_experiment { 12 namespace password_bubble_experiment {
12 namespace { 13 namespace {
13 14
14 const char kBrandingExperimentName[] = "PasswordBubbleBranding"; 15 const char kBrandingExperimentName[] = "PasswordBubbleBranding";
15 const char kSmartLockBrandingGroupName[] = "SmartLockBranding"; 16 const char kSmartLockBrandingGroupName[] = "SmartLockBranding";
16 17
17 } // namespace 18 } // namespace
18 19
19 void RecordBubbleClosed( 20 void RecordBubbleClosed(
20 PrefService* prefs, 21 PrefService* prefs,
21 password_manager::metrics_util::UIDismissalReason reason) { 22 password_manager::metrics_util::UIDismissalReason reason) {
22 // TODO(vasilii): store the statistics. 23 // TODO(vasilii): store the statistics.
23 } 24 }
24 25
25 bool IsEnabledSmartLockBranding(Profile* profile) { 26 bool IsEnabledSmartLockBranding(Profile* profile) {
26 SigninManagerBase* signin = SigninManagerFactory::GetForProfile(profile); 27 const ProfileSyncService* sync_service =
27 return (signin && signin->IsAuthenticated() && 28 ProfileSyncServiceFactory::GetForProfile(profile);
28 base::FieldTrialList::FindFullName(kBrandingExperimentName) == 29 return password_manager_util::GetPasswordSyncState(sync_service) &&
29 kSmartLockBrandingGroupName); 30 base::FieldTrialList::FindFullName(kBrandingExperimentName) ==
31 kSmartLockBrandingGroupName;
30 } 32 }
31 33
32 34
33 } // namespace password_bubble_experiment 35 } // namespace password_bubble_experiment
OLDNEW
« no previous file with comments | « chrome/browser/password_manager/password_manager_util.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698