[strong] Object literals create strong objects

src/bootstrapper.cc

Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index f2e51960fd962f849f114b31314e82d60873ceaf..6a6c870a908de341e394b263212ab1778484810d 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -1012,7 +1012,7 @@ void Genesis::InitializeGlobal(Handle<GlobalObject> global_object,
     native_context()->set_array_function(*array_function);
 
     // Cache the array maps, needed by ArrayConstructorStub
-    CacheInitialJSArrayMaps(native_context(), initial_map);
+    CacheInitialJSArrayMaps(native_context(), initial_map, false);

[Dmitry Lomov (no reviews), 2015/05/18 09:15:56]

Where do you call this function with 'true'?

[rossberg, 2015/05/18 09:32:37]

In JSFunction::SetInstancePrototype (objects.cc:10365), where it also calls it
with false again. To be honest, I don't understand this -- why is the
initialisation of the (weak) array maps happening in two places?

[Dmitry Lomov (no reviews), 2015/05/18 10:56:30]

Sounds like a bug/oversight - ask Yang or Ulan?

[rossberg, 2015/05/18 12:01:25]

Toon pointed out that the code here is to capture assignments to
Array.prototype. Added the setup in bootstrapper as well, plus a test (yet
inactive).

     ArrayConstructorStub array_constructor_stub(isolate);
     Handle<Code> code = array_constructor_stub.GetCode();
     array_function->shared()->set_construct_stub(*code);