[strong] Object literals create strong objects

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/utils/random-number-generator.h"
 #include "src/code-stubs.h"
@@ skipping 994 matching lines @@
       initial_map->AppendDescriptor(&d);
     }
 
     // array_function is used internally. JS code creating array object should
     // search for the 'Array' property on the global object and use that one
     // as the constructor. 'Array' property on a global object can be
     // overwritten by JS code.
     native_context()->set_array_function(*array_function);
 
     // Cache the array maps, needed by ArrayConstructorStub
-    CacheInitialJSArrayMaps(native_context(), initial_map);
+    CacheInitialJSArrayMaps(native_context(), initial_map, false);

[Dmitry Lomov (no reviews), 2015/05/18 09:15:56]

Where do you call this function with 'true'?

[rossberg, 2015/05/18 09:32:37]

In JSFunction::SetInstancePrototype (objects.cc:10365), where it also calls it
with false again. To be honest, I don't understand this -- why is the
initialisation of the (weak) array maps happening in two places?

[Dmitry Lomov (no reviews), 2015/05/18 10:56:30]

Sounds like a bug/oversight - ask Yang or Ulan?

[rossberg, 2015/05/18 12:01:25]

Toon pointed out that the code here is to capture assignments to
Array.prototype. Added the setup in bootstrapper as well, plus a test (yet
inactive).

     ArrayConstructorStub array_constructor_stub(isolate);
     Handle<Code> code = array_constructor_stub.GetCode();
     array_function->shared()->set_construct_stub(*code);
   }
 
   {  // --- N u m b e r ---
     Handle<JSFunction> number_fun =
         InstallFunction(global, "Number", JS_VALUE_TYPE, JSValue::kSize,
                         isolate->initial_object_prototype(),
                         Builtins::kIllegal);
@@ skipping 1997 matching lines @@
   return from + sizeof(NestingCounterType);
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 } }  // namespace v8::internal