Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1134323002: X87: Add a MathFloor stub generated with TurboFan (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Add a MathFloor stub generated with TurboFan port abc35080b33cc31e47b9913e64ac99ec687c6b65 (r28339) original commit message: This stub will be used as the basis of a Math.floor-specific CallIC to detect and track calls to floor that return -0. Along the way: - Create a TurboFanCodeStub super class from which the StringLength and MathRound TF stubs derive. - Fix the ugly hack that passes the first stub parameter as the "this" pointer in the the TF-compiled JS function. - Fix bugs in the ia32/x64 disassembler. BUG= Committed: https://crrev.com/6803006b2d0b77022ece49cd549fa57ca84a45f4 Cr-Commit-Position: refs/heads/master@{#28386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M src/x87/disasm-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-13 10:26:12 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-13 10:29:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134323002/1
5 years, 7 months ago (2015-05-13 10:29:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 11:14:40 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 11:14:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6803006b2d0b77022ece49cd549fa57ca84a45f4
Cr-Commit-Position: refs/heads/master@{#28386}

Powered by Google App Engine
This is Rietveld 408576698