Issue 11343041: Revert 164733 - Merge 164709 - Don't use CanonicalCookie::Create method for creating canonical cook…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11343041: Revert 164733 - Merge 164709 - Don't use CanonicalCookie::Create method for creating canonical cook… (Closed)

Created:
8 years, 1 month ago by karen

Modified:
8 years, 1 month ago

Reviewers:
markusheintz_

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/branches/1271/src/

Visibility:
Public.

Revert 164733 - Merge 164709 - Don't use CanonicalCookie::Create method for creating canonical cookies in the BrowsingDataCookieHelper. This results in wrong default values if no cookie-domain attribute is given in the cookie-string. BUG=158353 Review URL: https://codereview.chromium.org/11341011 TBR=markusheintz@chromium.org Review URL: https://codereview.chromium.org/11273090 TBR=markusheintz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164907

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -90 lines)			Patch
	M	chrome/browser/browsing_data/browsing_data_cookie_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc	View		5 chunks	+0 lines, -89 lines	0 comments	Download

Total messages: 1 (0 generated)