Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1195)

Issue 1134303012: Handle missing required arg in build/mac/find_sdk.py (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_pepper_44
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle missing required arg in build/mac/find_sdk.py Committed: https://crrev.com/99b518907669fbb280c764c5641a95361d43fdea Cr-Commit-Position: refs/heads/master@{#341756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/mac/find_sdk.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Sam Clegg
5 years, 4 months ago (2015-07-27 19:26:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1134303012/1
5 years, 4 months ago (2015-07-27 19:26:40 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-07-27 19:36:42 UTC) #6
Sam Clegg
ping
5 years, 4 months ago (2015-08-04 18:37:57 UTC) #7
Mark Mentovai
LGTM
5 years, 4 months ago (2015-08-04 18:39:42 UTC) #8
Mark Mentovai
LGTM
5 years, 4 months ago (2015-08-04 18:39:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1134303012/1
5 years, 4 months ago (2015-08-04 18:43:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-04 18:52:47 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-04 18:54:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99b518907669fbb280c764c5641a95361d43fdea
Cr-Commit-Position: refs/heads/master@{#341756}

Powered by Google App Engine
This is Rietveld 408576698