Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1134303006: [Effen] Rename SkyNodeWrapper and SkyElementWrapper to match their current actual roles, RenderNode… (Closed)

Created:
5 years, 7 months ago by Hixie
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

[Effen] Rename SkyNodeWrapper and SkyElementWrapper to match their current actual roles, RenderNodeWrapper and OneChildListRenderNodeWrapper. This lays the groundwork for supporting RenderNode classes that have more complicated child setups. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/56ce51b072855cf5cf38ef5f47a6b72ca4322153

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -33 lines) Patch
M sky/framework/fn.dart View 14 chunks +34 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-18 20:56:15 UTC) #2
Hixie
5 years, 7 months ago (2015-05-18 20:57:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56ce51b072855cf5cf38ef5f47a6b72ca4322153 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698