Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1134303004: JNI support for IsLoFiEnabled DataReductionProxySettings. (Closed)

Created:
5 years, 7 months ago by megjablon
Modified:
5 years, 7 months ago
Reviewers:
bengr
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@loFiExtraDataResponse
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

JNI support for IsLoFiEnabled in DataReductionProxySettings. BUG=484756 Committed: https://crrev.com/2a43817963db104c1e23bfd38c1cdaeaf0ddcb1a Cr-Commit-Position: refs/heads/master@{#330773}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/net/spdyproxy/DataReductionProxySettings.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
megjablon
5 years, 7 months ago (2015-05-18 18:14:47 UTC) #3
bengr
I must be missing something. What code displays the snackbar?
5 years, 7 months ago (2015-05-19 15:34:28 UTC) #4
megjablon
On 2015/05/19 15:34:28, bengr wrote: > I must be missing something. What code displays the ...
5 years, 7 months ago (2015-05-19 17:10:30 UTC) #5
bengr
On 2015/05/19 17:10:30, megjablon wrote: > On 2015/05/19 15:34:28, bengr wrote: > > I must ...
5 years, 7 months ago (2015-05-19 17:11:42 UTC) #6
megjablon
On 2015/05/19 17:11:42, bengr wrote: > On 2015/05/19 17:10:30, megjablon wrote: > > On 2015/05/19 ...
5 years, 7 months ago (2015-05-19 17:16:50 UTC) #7
bengr
On 2015/05/19 17:16:50, megjablon wrote: > On 2015/05/19 17:11:42, bengr wrote: > > On 2015/05/19 ...
5 years, 7 months ago (2015-05-19 17:57:14 UTC) #8
megjablon
On 2015/05/19 17:57:14, bengr wrote: > On 2015/05/19 17:16:50, megjablon wrote: > > On 2015/05/19 ...
5 years, 7 months ago (2015-05-19 18:08:42 UTC) #9
bengr
lgtm
5 years, 7 months ago (2015-05-19 18:26:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303004/20001
5 years, 7 months ago (2015-05-20 17:15:49 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-20 18:17:00 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 18:17:52 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a43817963db104c1e23bfd38c1cdaeaf0ddcb1a
Cr-Commit-Position: refs/heads/master@{#330773}

Powered by Google App Engine
This is Rietveld 408576698