Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1134303003: [turbofan] Turn JSTypedLowering into an AdvancedReducer. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn JSTypedLowering into an AdvancedReducer. This in turn allows usage of AdvancedReducer::ReplaceWithValue which has access to the underlying graph reducer. It will allow us to deal with exception continuations correctly. R=titzer@chromium.org Committed: https://crrev.com/329a3f220c9b094378b376db8735ef06a66f2024 Cr-Commit-Position: refs/heads/master@{#28468}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M src/compiler/graph-reducer.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 12 chunks +25 lines, -42 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-18 16:14:17 UTC) #1
titzer
LGTM if comments are addressed https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode532 src/compiler/js-typed-lowering.cc:532: return Changed(replacement); This should ...
5 years, 7 months ago (2015-05-19 08:43:13 UTC) #2
Michael Starzinger
Comments addressed. https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc File src/compiler/js-typed-lowering.cc (right): https://codereview.chromium.org/1134303003/diff/1/src/compiler/js-typed-lowering.cc#newcode532 src/compiler/js-typed-lowering.cc:532: return Changed(replacement); On 2015/05/19 08:43:13, titzer wrote: ...
5 years, 7 months ago (2015-05-19 09:32:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134303003/20001
5 years, 7 months ago (2015-05-19 09:45:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 09:57:59 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 09:58:18 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/329a3f220c9b094378b376db8735ef06a66f2024
Cr-Commit-Position: refs/heads/master@{#28468}

Powered by Google App Engine
This is Rietveld 408576698