Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Side by Side Diff: chrome_plugin_browsertest.cc

Issue 11343026: Disable ChromePluginTest.Flash for Linux (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/browser/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 (*count)++; 182 (*count)++;
183 } 183 }
184 } 184 }
185 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, quit_task); 185 BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, quit_task);
186 } 186 }
187 }; 187 };
188 188
189 // Tests a bunch of basic scenarios with Flash. 189 // Tests a bunch of basic scenarios with Flash.
190 // This test fails under ASan on Mac, see http://crbug.com/147004. 190 // This test fails under ASan on Mac, see http://crbug.com/147004.
191 // It fails elsewhere, too. See http://crbug.com/152071. 191 // It fails elsewhere, too. See http://crbug.com/152071.
192 #if defined(ADDRESS_SANITIZER) || defined(OS_MACOSX) || defined(OS_WIN) 192 #if defined(ADDRESS_SANITIZER) || defined(OS_MACOSX) || defined(OS_WIN) || \
yzshen1 2012/10/30 00:10:38 Is there any other platform left? You might want
193 defined(OS_LINUX)
193 #define MAYBE_Flash DISABLED_Flash 194 #define MAYBE_Flash DISABLED_Flash
194 #else 195 #else
195 #define MAYBE_Flash Flash 196 #define MAYBE_Flash Flash
196 #endif 197 #endif
197 IN_PROC_BROWSER_TEST_F(ChromePluginTest, MAYBE_Flash) { 198 IN_PROC_BROWSER_TEST_F(ChromePluginTest, MAYBE_Flash) {
198 // Official builds always have bundled Flash. 199 // Official builds always have bundled Flash.
199 #if !defined(OFFICIAL_BUILD) 200 #if !defined(OFFICIAL_BUILD)
200 std::vector<FilePath> flash_paths; 201 std::vector<FilePath> flash_paths;
201 GetFlashPath(&flash_paths); 202 GetFlashPath(&flash_paths);
202 if (flash_paths.empty()) { 203 if (flash_paths.empty()) {
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 std::vector<webkit::WebPluginInfo> plugins = GetPlugins(); 259 std::vector<webkit::WebPluginInfo> plugins = GetPlugins();
259 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(expected); ++i) { 260 for (size_t i = 0; i < ARRAYSIZE_UNSAFE(expected); ++i) {
260 size_t j = 0; 261 size_t j = 0;
261 for (; j < plugins.size(); ++j) { 262 for (; j < plugins.size(); ++j) {
262 if (plugins[j].name == ASCIIToUTF16(expected[i])) 263 if (plugins[j].name == ASCIIToUTF16(expected[i]))
263 break; 264 break;
264 } 265 }
265 ASSERT_TRUE(j != plugins.size()) << "Didn't find " << expected[i]; 266 ASSERT_TRUE(j != plugins.size()) << "Didn't find " << expected[i];
266 } 267 }
267 } 268 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698