Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11343017: Move remaining files in content\browser\renderer_host to content namespace. (Closed)

Created:
8 years, 1 month ago by jam
Modified:
8 years, 1 month ago
Reviewers:
tfarina
CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

Move remaining files in content\browser\renderer_host to content namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164713

Patch Set 1 #

Patch Set 2 : fix linux #

Patch Set 3 : fix linux #

Total comments: 7

Patch Set 4 : fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -218 lines) Patch
M base/threading/thread_restrictions.h View 1 2 3 4 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_mac.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_mac.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_manager_mac.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/accelerated_surface_container_manager_mac.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/gesture_event_filter.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/gtk_key_bindings_handler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/browser/renderer_host/gtk_key_bindings_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/gtk_key_bindings_handler_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.h View 4 chunks +6 lines, -5 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/ime_adapter_android.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/java/java_bound_object.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_bound_object.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_channel_host.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/java/java_bridge_channel_host.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.h View 4 chunks +7 lines, -6 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.h View 3 chunks +10 lines, -13 lines 0 comments Download
M content/browser/renderer_host/java/java_bridge_dispatcher_host_manager.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M content/browser/renderer_host/java/java_method.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_method.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_type.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/java/java_type.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/native_web_keyboard_event_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.h View 4 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_view_host_factory.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_manager_browsertest.cc View 8 chunks +14 lines, -17 lines 0 comments Download
M content/browser/renderer_host/render_view_host_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_mac.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 14 chunks +24 lines, -34 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win_browsertest.cc View 10 chunks +28 lines, -30 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/tap_suppression_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/tap_suppression_controller_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/test_render_view_host.h View 3 chunks +3 lines, -4 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_mac_unittest.mm View 3 chunks +4 lines, -8 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/renderer_host/text_input_client_message_filter.mm View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/throttling_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/touch_event_queue.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/render_view_host_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 1 month ago (2012-10-29 17:41:08 UTC) #1
tfarina
8 years, 1 month ago (2012-10-29 18:17:39 UTC) #2 
lgtm

https://codereview.chromium.org/11343017/diff/8007/content/browser/android/br...
File content/browser/android/browser_jni_registrar.cc (right):

https://codereview.chromium.org/11343017/diff/8007/content/browser/android/br...
content/browser/android/browser_jni_registrar.cc:39: { "JavaBoundObject",
content::JavaBoundObject::RegisterJavaBoundObject },
do we want to wrap the unnamed namespace in content namespace, as we have been
doing?

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
File content/browser/renderer_host/java/java_bridge_channel_host.cc (right):

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/java/java_bridge_channel_host.cc:17: struct
WaitableEventLazyInstanceTraits
I'd put blank lines between these things to increase the readability of this
unnamed section.

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/java/java_bridge_channel_host.cc:25:
base::LazyInstance<WaitableEvent, WaitableEventLazyInstanceTraits> dummy_event =
likewise

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/java/java_bridge_channel_host.cc:29: }
// namespace

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/java/java_bridge_channel_host.cc:29: }
likewise

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
File content/browser/renderer_host/render_widget_host_unittest.cc (right):

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/render_widget_host_unittest.cc:387: void SetUp() {
sorry for point out, but is missing 'virtual' and 'OVERRIDE' same for TearDown.

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
File content/browser/renderer_host/tap_suppression_controller.cc (right):

https://codereview.chromium.org/11343017/diff/8007/content/browser/renderer_h...
content/browser/renderer_host/tap_suppression_controller.cc:30: } // namespace
content
one more space between } and //

Powered by Google App Engine
This is Rietveld 408576698