Issue 11343013: Move content\browser\net to content namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11343013: Move content\browser\net to content namespace. (Closed)

Created:
8 years, 1 month ago by jam

Modified:
8 years, 1 month ago

Reviewers:
tfarina

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, cbentzel+watch_chromium.org, darin-cc_chromium.org, gavinp+disk_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move content\browser\net to content namespace. TBR=tfarina Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164665

Patch Set 1 #

Total comments: 3

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -4 lines)			Patch
M	content/browser/browser_main_loop.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	content/browser/net/browser_online_state_observer.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/net/browser_online_state_observer.cc	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	content/browser/net/view_blob_internals_job_factory.h	View	2 chunks	+4 lines, -0 lines	1 comment	Download
M	content/browser/net/view_blob_internals_job_factory.cc	View	2 chunks	+4 lines, -0 lines	2 comments	Download
M	content/browser/net/view_http_cache_job_factory.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	content/browser/net/view_http_cache_job_factory.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tfarina

8 years, 1 month ago (2012-10-29 16:26:25 UTC) #2

lgtm

https://codereview.chromium.org/11343013/diff/1/content/browser/net/view_blob...
File content/browser/net/view_blob_internals_job_factory.cc (right):

https://codereview.chromium.org/11343013/diff/1/content/browser/net/view_blob...
content/browser/net/view_blob_internals_job_factory.cc:7: #include
"base/memory/scoped_ptr.h"
remove this include

https://codereview.chromium.org/11343013/diff/1/content/browser/net/view_blob...
content/browser/net/view_blob_internals_job_factory.cc:8: #include
"base/string_util.h"
also unused.

https://codereview.chromium.org/11343013/diff/1/content/browser/net/view_blob...
File content/browser/net/view_blob_internals_job_factory.h (right):

https://codereview.chromium.org/11343013/diff/1/content/browser/net/view_blob...
content/browser/net/view_blob_internals_job_factory.h:13: namespace webkit_blob
{
nit: blank line between line 12-13

Expand Messages | Collapse Messages