Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 11343011: Simplified HCheckMaps handling a bit. (Closed)

Created:
8 years, 1 month ago by Sven Panne
Modified:
8 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Simplified HCheckMaps handling a bit. This is a refactoring-only CL which simplifies the way we emit combinations of Smi+map checks. Committed: https://code.google.com/p/v8/source/detail?r=12848

Patch Set 1 #

Patch Set 2 : Removed default argument #

Patch Set 3 : Rebased and polished #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M src/hydrogen.h View 1 3 chunks +9 lines, -6 lines 0 comments Download
M src/hydrogen.cc View 1 2 20 chunks +43 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
8 years, 1 month ago (2012-10-29 15:20:21 UTC) #1
Toon Verwaest
lgtm
8 years, 1 month ago (2012-10-30 09:25:21 UTC) #2
Sven Panne
As discussed offline, here is a new version without default arguments. PTAL...
8 years, 1 month ago (2012-10-30 10:35:11 UTC) #3
Toon Verwaest
8 years, 1 month ago (2012-10-30 11:55:51 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698