tools/testing/dart/test_suite.dart - Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comment. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_suite.dart

diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart

index cde22b07f2b7af550f11ccf7df255f0d3de6d516..dd639df668a09bff92ad44321dcf5f705b5e2643 100644

--- a/tools/testing/dart/test_suite.dart

+++ b/tools/testing/dart/test_suite.dart

@@ -67,6 +67,8 @@ void ccTestLister() {

port.receive((String runnerPath, SendPort replyTo) {

Future processFuture = Process.start(runnerPath, ["--list"]);

processFuture.then((p) {

+ // Drain stderr to not leak resources.

+ p.stderr.onData = p.stderr.read;

StringInputStream stdoutStream = new StringInputStream(p.stdout);

var streamDone = false;

var processExited = false;

« no previous file with comments | « tools/testing/dart/test_runner.dart ('k') | utils/testrunner/layout_test_controller.dart » ('j') | no next file with comments »