Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Unified Diff: tests/standalone/io/process_working_directory_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/process_stdout_test.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/process_working_directory_test.dart
diff --git a/tests/standalone/io/process_working_directory_test.dart b/tests/standalone/io/process_working_directory_test.dart
index 1255518b0b523e9f982302a6c1c8b48347178dce..6040b53ea0e2e7af7a760e89b3864ab59c667060 100644
--- a/tests/standalone/io/process_working_directory_test.dart
+++ b/tests/standalone/io/process_working_directory_test.dart
@@ -27,9 +27,10 @@ class ProcessWorkingDirectoryTest {
processFuture.then((process) {
process.onExit = (int exitCode) {
Expect.equals(exitCode, 99);
- process.close();
directory.deleteSync();
};
+ process.stdout.onData = process.stdout.read;
+ process.stderr.onData = process.stderr.read;
});
processFuture.handleException((error) {
directory.deleteSync();
@@ -48,7 +49,6 @@ class ProcessWorkingDirectoryTest {
options);
future.then((process) {
Expect.fail("bad process completed");
- process.close();
directory.deleteSync();
});
« no previous file with comments | « tests/standalone/io/process_stdout_test.dart ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698