Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Side by Side Diff: tests/standalone/io/process_stdout_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Process test program to test process communication. 5 // Process test program to test process communication.
6 // 6 //
7 // VMOptions= 7 // VMOptions=
8 // VMOptions=--short_socket_read 8 // VMOptions=--short_socket_read
9 // VMOptions=--short_socket_write 9 // VMOptions=--short_socket_write
10 // VMOptions=--short_socket_read --short_socket_write 10 // VMOptions=--short_socket_read --short_socket_write
11 11
12 #import("dart:io"); 12 #import("dart:io");
13 #import("dart:math"); 13 #import("dart:math");
14 14
15 #source("process_test_util.dart"); 15 #source("process_test_util.dart");
16 16
17 void test(Future<Process> future, int expectedExitCode) { 17 void test(Future<Process> future, int expectedExitCode) {
18 future.then((process) { 18 future.then((process) {
19 process.onExit = (exitCode) { 19 process.onExit = (exitCode) {
20 Expect.equals(expectedExitCode, exitCode); 20 Expect.equals(expectedExitCode, exitCode);
21 }; 21 };
22 22
23 List<int> data = "ABCDEFGHI\n".charCodes; 23 List<int> data = "ABCDEFGHI\n".charCodes;
24 final int dataSize = data.length; 24 final int dataSize = data.length;
25 25
26 InputStream input = process.stdout; 26 InputStream out = process.stdout;
27 OutputStream output = process.stdin;
28 27
29 int received = 0; 28 int received = 0;
30 List<int> buffer = []; 29 List<int> buffer = [];
31 30
32 void readData() { 31 void readData() {
33 buffer.addAll(input.read()); 32 buffer.addAll(out.read());
34 for (int i = received; 33 for (int i = received;
35 i < min(data.length, buffer.length) - 1; 34 i < min(data.length, buffer.length) - 1;
36 i++) { 35 i++) {
37 Expect.equals(data[i], buffer[i]); 36 Expect.equals(data[i], buffer[i]);
38 } 37 }
39 received = buffer.length; 38 received = buffer.length;
40 if (received >= dataSize) { 39 if (received >= dataSize) {
41 // We expect an extra character on windows due to carriage return. 40 // We expect an extra character on windows due to carriage return.
42 if (13 === buffer[dataSize - 1] && dataSize + 1 === received) { 41 if (13 === buffer[dataSize - 1] && dataSize + 1 === received) {
43 Expect.equals(13, buffer[dataSize - 1]); 42 Expect.equals(13, buffer[dataSize - 1]);
44 Expect.equals(10, buffer[dataSize]); 43 Expect.equals(10, buffer[dataSize]);
45 buffer.removeLast(); 44 buffer.removeLast();
46 process.close();
47 } else if (received === dataSize) {
48 process.close();
49 } 45 }
50 } 46 }
51 } 47 }
52 48
53 output.write(data); 49 process.stdin.write(data);
54 output.close(); 50 process.stdin.close();
55 input.onData = readData; 51 out.onData = readData;
52 process.stderr.onData = process.stderr.read;
56 }); 53 });
57 } 54 }
58 55
59 main() { 56 main() {
60 // Run the test using the process_test binary. 57 // Run the test using the process_test binary.
61 test(Process.start(getProcessTestFileName(), 58 test(Process.start(getProcessTestFileName(),
62 const ["0", "1", "99", "0"]), 99); 59 const ["0", "1", "99", "0"]), 99);
63 60
64 // Run the test using the dart binary with an echo script. 61 // Run the test using the dart binary with an echo script.
65 // The test runner can be run from either the root or from runtime. 62 // The test runner can be run from either the root or from runtime.
66 var scriptFile = new File("tests/standalone/io/process_std_io_script.dart"); 63 var scriptFile = new File("tests/standalone/io/process_std_io_script.dart");
67 if (!scriptFile.existsSync()) { 64 if (!scriptFile.existsSync()) {
68 scriptFile = new File("../tests/standalone/io/process_std_io_script.dart"); 65 scriptFile = new File("../tests/standalone/io/process_std_io_script.dart");
69 } 66 }
70 Expect.isTrue(scriptFile.existsSync()); 67 Expect.isTrue(scriptFile.existsSync());
71 test(Process.start(new Options().executable, [scriptFile.name, "0"]), 0); 68 test(Process.start(new Options().executable, [scriptFile.name, "0"]), 0);
72 } 69 }
OLDNEW
« no previous file with comments | « tests/standalone/io/process_stderr_test.dart ('k') | tests/standalone/io/process_working_directory_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698