Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: tests/standalone/io/process_segfault_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Process test program to test process communication. 5 // Process test program to test process communication.
6 6
7 #library("ProcessSegfaultTest"); 7 #library("ProcessSegfaultTest");
8 #import("dart:io"); 8 #import("dart:io");
9 #source("process_test_util.dart"); 9 #source("process_test_util.dart");
10 10
11 testExit() { 11 testExit() {
12 var future = Process.start(getProcessTestFileName(), 12 var future = Process.start(getProcessTestFileName(),
13 const ["0", "0", "1", "1"]); 13 const ["0", "0", "1", "1"]);
14 future.then((process) { 14 future.then((process) {
15 process.onExit = (int exitCode) { 15 process.onExit = (int exitCode) {
16 Expect.isTrue(exitCode != 0); 16 Expect.isTrue(exitCode != 0);
17 process.close();
18 }; 17 };
18 process.stdout.onData = process.stdout.read;
19 process.stderr.onData = process.stderr.read;
19 }); 20 });
20 } 21 }
21 22
22 23
23 testExitRun() { 24 testExitRun() {
24 Process.run(getProcessTestFileName(), 25 Process.run(getProcessTestFileName(),
25 const ["0", "0", "1", "1"]).then((result) { 26 const ["0", "0", "1", "1"]).then((result) {
26 Expect.isTrue(result.exitCode != 0); 27 Expect.isTrue(result.exitCode != 0);
27 Expect.equals(result.stdout, ''); 28 Expect.equals(result.stdout, '');
28 Expect.equals(result.stderr, ''); 29 Expect.equals(result.stderr, '');
29 }); 30 });
30 } 31 }
31 32
32 33
33 main() { 34 main() {
34 testExit(); 35 testExit();
35 testExitRun(); 36 testExitRun();
36 } 37 }
OLDNEW
« no previous file with comments | « tests/standalone/io/process_exit_test.dart ('k') | tests/standalone/io/process_stderr_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698