Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: tests/standalone/io/process_broken_pipe_test.dart

Issue 11343009: Get rid of 'close' on process. It is very easy to use incorrectly and cut off data from your stream… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // 4 //
5 // Process test program to test closed stdin from child process. 5 // Process test program to test closed stdin from child process.
6 6
7 #import('dart:io'); 7 #import('dart:io');
8 8
9 #source("process_test_util.dart"); 9 #source("process_test_util.dart");
10 10
11 main() { 11 main() {
12 // Running dart without arguments makes it close right away. 12 // Running dart without arguments makes it close right away.
13 var future = Process.start(new Options().executable, []); 13 var future = Process.start(new Options().executable, []);
14 future.then((process) { 14 future.then((process) {
15 // Ignore error on stdin. 15 // Ignore error on stdin.
16 process.stdin.onError = (e) => null; 16 process.stdin.onError = (e) => null;
17 17
18 // Drain stdout and stderr.
19 process.stdout.onData = () => process.stdout.read();
20 process.stderr.onData = () => process.stderr.read();
21
18 // Write to the stdin after the process is terminated to test 22 // Write to the stdin after the process is terminated to test
19 // writing to a broken pipe. 23 // writing to a broken pipe.
20 process.onExit = (code) { 24 process.onExit = (code) {
21 Expect.isFalse(process.stdin.write([0])); 25 Expect.isFalse(process.stdin.write([0]));
22 process.close();
23 }; 26 };
24 }); 27 });
25 } 28 }
OLDNEW
« no previous file with comments | « tests/standalone/io/dart_std_io_pipe_test.dart ('k') | tests/standalone/io/process_check_arguments_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698