Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: tools/testing/dart/test_options.dart

Issue 11343008: Land update to tools directory with new binaries. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index eae9f12432d5b19cfcf81e1d5509fc0fbd523707..97301ea31884cda2f017b8fdf322cb9c9d0c1cfc 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -353,7 +353,7 @@ Note: currently only implemented for dart2js.''',
}
// Parse the value for the option.
if (spec.type == 'bool') {
- if (!value.isEmpty()) {
+ if (!value.isEmpty) {
print('No value expected for bool option $name');
exit(1);
}
@@ -367,7 +367,7 @@ Note: currently only implemented for dart2js.''',
}
} else {
assert(spec.type == 'string');
- if (!spec.values.isEmpty()) {
+ if (!spec.values.isEmpty) {
for (var v in value.split(',')) {
if (spec.values.lastIndexOf(v) == -1) {
print('Unknown value ($v) for option $name');
@@ -388,7 +388,7 @@ Note: currently only implemented for dart2js.''',
List<Map> expandedConfigs = _expandConfigurations(configuration);
List<Map> result = expandedConfigs.filter(_isValidConfig);
- return result.isEmpty() ? null : result;
+ return result.isEmpty ? null : result;
}
/**
@@ -624,11 +624,11 @@ Note: currently only implemented for dart2js.''',
var buffer = new StringBuffer();;
buffer.add(name);
if (option.type == 'bool') {
- assert(option.values.isEmpty());
+ assert(option.values.isEmpty);
} else {
buffer.add(name.startsWith('--') ? '=' : ' ');
if (option.type == 'int') {
- assert(option.values.isEmpty());
+ assert(option.values.isEmpty);
buffer.add('n (default: ${option.defaultValue})');
} else {
buffer.add('[');
« no previous file with comments | « tools/testing/dart/status_file_parser.dart ('k') | tools/testing/dart/test_progress.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698