Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11343004: drive: Add "Delta Update Status" section to chrome:drive-internals (Closed)

Created:
8 years, 1 month ago by satorux1
Modified:
8 years, 1 month ago
Reviewers:
Lei Zhang, kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, achuith+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Add "Delta Update Status" section to chrome:drive-internals This section exposes information related to delta update like polling interval. BUG=157109 TEST=go to chrome:drive-internals and confirm "Delta Update Status" section is added Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165315

Patch Set 1 : polish #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : address comments #

Patch Set 4 : fix the initializer #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -14 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.h View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 2 3 4 4 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_interface.h View 2 chunks +1 line, -9 lines 0 comments Download
A chrome/browser/chromeos/drive/drive_file_system_metadata.h View 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/drive/drive_file_system_metadata.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.html View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/drive_internals.js View 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 3 chunks +24 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
thestig@ for gyp change kinaba@ everything else
8 years, 1 month ago (2012-10-29 07:14:35 UTC) #1
kinaba
lgtm with one nit. http://codereview.chromium.org/11343004/diff/1001/chrome/browser/chromeos/drive/drive_file_system.h File chrome/browser/chromeos/drive/drive_file_system.h (right): http://codereview.chromium.org/11343004/diff/1001/chrome/browser/chromeos/drive/drive_file_system.h#newcode761 chrome/browser/chromeos/drive/drive_file_system.h:761: bool push_notification_enabled_; This variable and ...
8 years, 1 month ago (2012-10-29 13:12:34 UTC) #2
Lei Zhang
gyp file change lgtm
8 years, 1 month ago (2012-10-29 21:29:40 UTC) #3
satorux1
http://codereview.chromium.org/11343004/diff/1001/chrome/browser/chromeos/drive/drive_file_system.h File chrome/browser/chromeos/drive/drive_file_system.h (right): http://codereview.chromium.org/11343004/diff/1001/chrome/browser/chromeos/drive/drive_file_system.h#newcode761 chrome/browser/chromeos/drive/drive_file_system.h:761: bool push_notification_enabled_; On 2012/10/29 13:12:34, kinaba wrote: > This ...
8 years, 1 month ago (2012-11-01 07:20:23 UTC) #4
commit-bot: I haz the power
8 years, 1 month ago (2012-11-01 07:22:06 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698