Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: chrome/browser/safe_browsing/ping_manager.cc

Issue 1134283003: Add HTTP certificate report URL with Finch gate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/certificate_error_reporter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/ping_manager.cc
diff --git a/chrome/browser/safe_browsing/ping_manager.cc b/chrome/browser/safe_browsing/ping_manager.cc
index 92228ca821942814cf561f7dcccb34a33a06de08..ac20c636c608690aa2df9e93b2dfdbf5eee609fa 100644
--- a/chrome/browser/safe_browsing/ping_manager.cc
+++ b/chrome/browser/safe_browsing/ping_manager.cc
@@ -27,8 +27,9 @@ namespace {
// URLs to upload invalid certificate chain reports. The HTTP URL is
// preferred since a client seeing an invalid cert might not be able to
// make an HTTPS connection to report it.
-// TODO(estark): insert the production HTTP URL when it's ready
-const char kExtendedReportingUploadUrlInsecure[] = "";
+const char kExtendedReportingUploadUrlInsecure[] =
+ "http://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
+ "chrome-certs";
const char kExtendedReportingUploadUrlSecure[] =
"https://sb-ssl.google.com/safebrowsing/clientreport/chrome-certs";
} // namespace
@@ -55,8 +56,7 @@ SafeBrowsingPingManager::SafeBrowsingPingManager(
// Set the upload URL and whether or not to send cookies with
// certificate reports sent to Safe Browsing servers.
bool use_insecure_certificate_upload_url =
- CertificateErrorReporter::IsHttpUploadUrlSupported() &&
- strlen(kExtendedReportingUploadUrlInsecure) > 0;
+ CertificateErrorReporter::IsHttpUploadUrlSupported();
CertificateErrorReporter::CookiesPreference cookies_preference;
GURL certificate_upload_url;
« no previous file with comments | « chrome/browser/net/certificate_error_reporter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698