Band-aid fix for bug 487406

Band-aid fix for bug 487406

There is certainly a deeper issue here, but since I expect RenderFrameProxyHost::render_frame_host_ to be disappearing very soon, this small fix seems okay to suppress the crash.

BUG=487406
Committed: https://crrev.com/dcc838da72fb1f7694e9bd41b47e903286f5cca5
Cr-Commit-Position: refs/heads/master@{#329867}

[ncarter (slow), 2015-05-14 04:01:33]

nick@chromium.org changed reviewers:
+ nasko@chromium.org

[nasko, 2015-05-14 14:09:01]

LGTM

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_manager.cc (right):

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_manager.cc:940:
proxy->render_frame_host() &&
Funny enough, I had this exact change in my CL to swap the main frame.

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_proxy_host.cc (right):

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_proxy_host.cc:102:
CHECK(render_frame_host_ == nullptr);
CHECK_EQ?

[ncarter (slow), 2015-05-14 17:16:13]

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
File content/browser/frame_host/render_frame_proxy_host.cc (right):

https://codereview.chromium.org/1134273002/diff/20001/content/browser/frame_h...
content/browser/frame_host/render_frame_proxy_host.cc:102:
CHECK(render_frame_host_ == nullptr);
On 2015/05/14 14:09:01, nasko wrote:
> CHECK_EQ?

Tried five things:

CHECK(render_frame_host_ == nullptr);  // Compiles
CHECK_EQ(render_frame_host_, nullptr);  // Doesn't compile
CHECK_EQ(render_frame_host_.get(), nullptr);  // Doesn't compile either
CHECK_EQ(render_frame_host_, static_cast<RenderFrameHost*>(nullptr));  // Still
doesn't compile.
CHECK_EQ(render_frame_host_.get(), static_cast<RenderFrameHost*>(nullptr));  //
Compiles! But at what cost?

There are some (but not many) examples of option 5 in the codebase:
https://code.google.com/p/chromium/codesearch#search/&q=CHECK_EQ.*nullptr&sq=...

I think the version with operator== is easiest on the eyes. CHECK_EQ(ptr1, ptr2)
is a good idea if you have two pointers variables that you expect to be equal,
because then stdout will show you which of the mismatched address values is null
or not. But if you're testing the value of a single pointer value against
nullity, I don't think it helps much to see the particular non-null address on
stdout.

[ncarter (slow), 2015-05-14 17:16:17]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2015-05-14 17:17:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1134273002/20001

[commit-bot: I haz the power, 2015-05-14 17:22:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-14 17:23:11]

Patchset 2 (id:??) landed as
https://crrev.com/dcc838da72fb1f7694e9bd41b47e903286f5cca5
Cr-Commit-Position: refs/heads/master@{#329867}