Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1134253002: Revert of Cache IsNonBrowserProcess values, so we only take a loader-lock the first time. (Closed)

Created:
5 years, 7 months ago by Cait (Slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cache IsNonBrowserProcess values, so we only take a loader-lock the first time. (patchset #4 id:60001 of https://codereview.chromium.org/1132473003/) Reason for revert: Possibly causing mysterious fails on the Win DBG bots: https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/16344 http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37896 Original issue's description: > Cache IsNonBrowserProcess values, so we only take a loader-lock the first time. > > BUG=485656, 477137 > > Committed: https://crrev.com/78d41b5d4e59dc7d52d7e7d6530fdd0a78b36d33 > Cr-Commit-Position: refs/heads/master@{#329246} TBR=siggi@chromium.org,grt@chromium.org,csharp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=485656, 477137 Committed: https://crrev.com/88dc419e9573a08c229dbe4cc73c9b2b0cbd392a Cr-Commit-Position: refs/heads/master@{#329467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -45 lines) Patch
M chrome_elf/blacklist/test/blacklist_test_main_dll.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome_elf/chrome_elf_util.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome_elf/chrome_elf_util.cc View 2 chunks +11 lines, -23 lines 0 comments Download
M chrome_elf/chrome_elf_util_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Cait (Slow)
Created Revert of Cache IsNonBrowserProcess values, so we only take a loader-lock the first time.
5 years, 7 months ago (2015-05-12 19:55:34 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-12 19:56:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134253002/1
5 years, 7 months ago (2015-05-12 19:57:01 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 19:59:06 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 19:59:47 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88dc419e9573a08c229dbe4cc73c9b2b0cbd392a
Cr-Commit-Position: refs/heads/master@{#329467}

Powered by Google App Engine
This is Rietveld 408576698