Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1134233002: Revert of Adding total available size of heap in v8 isolate memory dump provider. (Closed)

Created:
5 years, 7 months ago by ssid
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding total available size of heap in v8 isolate memory dump provider. (patchset #1 id:1 of https://codereview.chromium.org/1129403003/) Reason for revert: The HeapStatistics::total_available_size returned by v8 API doesn't return the correct value right now. It only returns the sum of available size of 4 spaces only. So, this should land after the API gets fixed. Original issue's description: > Adding total available size of heap in v8 isolate memory dump provider. > > The total available size is now returned by GetHeapStatistics api. > This CL uses the value in the dump provider to show the value in > other_spaces segment of the memory dump. > > BUG=481504 > > Committed: https://crrev.com/9ad94e6e06201059c08d67b9d9ab4a30a766b541 > Cr-Commit-Position: refs/heads/master@{#329303} TBR=jochen@chromium.org,picksi@chromium.org,primiano@chromium.org BUG=481504 Committed: https://crrev.com/b765e2ad9225ecca8c89d535870365d33e9a728f Cr-Commit-Position: refs/heads/master@{#329479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M gin/v8_isolate_memory_dump_provider.cc View 4 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ssid
Created Revert of Adding total available size of heap in v8 isolate memory dump provider.
5 years, 7 months ago (2015-05-12 16:19:31 UTC) #1
ssid
Sorry, there was an error in API, which I just realized.
5 years, 7 months ago (2015-05-12 16:20:04 UTC) #2
Primiano Tucci (use gerrit)
LGTM. P.S. I removed the NOTRY / NOTREECHECKS for you as this is not fixing ...
5 years, 7 months ago (2015-05-12 16:38:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1134233002/1
5 years, 7 months ago (2015-05-12 19:45:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 20:46:26 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 20:47:44 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b765e2ad9225ecca8c89d535870365d33e9a728f
Cr-Commit-Position: refs/heads/master@{#329479}

Powered by Google App Engine
This is Rietveld 408576698